Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename main class from IOSSecuritySuite to SecuritySuiteiOS #91

Closed
wants to merge 1 commit into from

Conversation

DevAgani
Copy link

Fixes : #90

Proposal, rename the IOSSecuritySuite to SecuritySuiteiOS to ensure that the library name doesn't clash with the Main class.
This is an extreme approach, but has benefits

  • Users of the library will only need to update the places where they're calling the library
  • Decided to and the suffice iOS to indicate that this set of Security features are available for iOS

So instead of

if IOSSecuritySuite.amIJailbroken() {
	print("This device is jailbroken")
} else {
	print("This device is not jailbroken")
}

Becomes

if SecuritySuiteiOS.amIJailbroken() {
	print("This device is jailbroken")
} else {
	print("This device is not jailbroken")
}

On the extreme end, this will be a breaking change, so it means this needs to be handled with extreme care.

@DevAgani DevAgani changed the title Rename IOSSecuritySuite to SecuritySuiteiOS [#90] - Rename main class from IOSSecuritySuite to SecuritySuiteiOS May 17, 2023
@DevAgani DevAgani changed the title [#90] - Rename main class from IOSSecuritySuite to SecuritySuiteiOS Rename main class from IOSSecuritySuite to SecuritySuiteiOS May 17, 2023
@r3ggi
Copy link
Collaborator

r3ggi commented May 17, 2023

Sorry, I'm not going to change this library name because of a Swift compiler bug that's already being fixed and rarely happens.

@r3ggi r3ggi closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library + Main Class name clash
2 participants