Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swapping to internal references #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gregory-Pereira
Copy link

@openshift-ci openshift-ci bot requested review from lance and osmman March 5, 2024 20:22
Copy link

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by

  1. Building the Dockerfile and using it in the operator (All good)
  2. Ran 'make test' (All Good)

I then tried to run make fulcio and I ran into this error:

protoc --plugin=protoc-gen-go=/home/japower/Projects/go-workspace/src/work/securesign/fulcio/hack/tools/bin/protoc-gen-go \
       --go_opt=module=github.com/securesign/fulcio --go_out=. \
       --plugin=protoc-gen-go-grpc=/home/japower/Projects/go-workspace/src/work/securesign/fulcio/hack/tools/bin/protoc-gen-go-grpc \
       --go-grpc_opt=module=github.com/securesign/fulcio --go-grpc_out=. \
       --plugin=protoc-gen-grpc-gateway=/home/japower/Projects/go-workspace/src/work/securesign/fulcio/hack/tools/bin/protoc-gen-grpc-gateway \
       --grpc-gateway_opt=module=github.com/securesign/fulcio --grpc-gateway_opt=logtostderr=true --grpc-gateway_out=. \
       --plugin=protoc-gen-openapiv2=/home/japower/Projects/go-workspace/src/work/securesign/fulcio/hack/tools/bin/protoc-gen-openapiv2 \
       --openapiv2_out . \
           -I third_party/googleapis/ -I . ./fulcio_legacy.proto ./fulcio.proto
--go_out: github.com/sigstore/fulcio/pkg/generated/protobuf/legacy/fulcio_legacy.pb.go: generated file does not match prefix "github.com/securesign/fulcio"
make: *** [Makefile:59: pkg/generated/protobuf/%.go] Error 1

Changes need to made in the fulcio_legacy.proto and fulcio.proto to reflect the changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants