Simplify sortIssues implementation#1277
Merged
ccojocar merged 1 commit intosecurego:masterfrom Dec 20, 2024
alexandear:refactor/simplify-sortissues
Merged
Simplify sortIssues implementation#1277ccojocar merged 1 commit intosecurego:masterfrom alexandear:refactor/simplify-sortissues
ccojocar merged 1 commit intosecurego:masterfrom
alexandear:refactor/simplify-sortissues
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
- Coverage 68.49% 66.62% -1.88%
==========================================
Files 75 75
Lines 4384 5186 +802
==========================================
+ Hits 3003 3455 +452
- Misses 1233 1582 +349
- Partials 148 149 +1 ☔ View full report in Codecov by Sentry. |
ccojocar
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the help of
slices.SortFuncand thecmppackage, this PR simplifies the implementation ofsortIssues.