Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback the SARIF version to 2.1 since github doesn't support 2.2 #1210

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

ccojocar
Copy link
Member

@ccojocar ccojocar commented Sep 4, 2024

No description provided.

Change-Id: If3500ec2c522339ca0a4e6c1f58574ce3cc870a9
Signed-off-by: Cosmin Cojocar <[email protected]>
@ccojocar ccojocar merged commit 0ce4453 into master Sep 4, 2024
3 of 5 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (ea26e84) to head (8f3524d).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1210   +/-   ##
=======================================
  Coverage   68.48%   68.48%           
=======================================
  Files          75       75           
  Lines        4360     4360           
=======================================
  Hits         2986     2986           
  Misses       1226     1226           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niij
Copy link

niij commented Sep 6, 2024

^ I have the same issue as the linked PR above (@Michad). Our builds are failing with a rejection from github that the SARIF file is invalid. This is occurring when using both of the following actions:

  • securego/gosec@master (v2.21.1 014751c)
  • github/codeql-action/upload-sarif (v2.26.6 be8b74c09c1778bcdbea38e1a45efea2cb73e18c)

I'm pinning securego/[email protected] as a workaround for now.

@ccojocar ccojocar deleted the sarif-revert branch September 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants