Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure basis function modules #63

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Restructure basis function modules #63

merged 4 commits into from
Dec 15, 2021

Conversation

ltiao
Copy link
Collaborator

@ltiao ltiao commented Dec 13, 2021

No description provided.

@ltiao ltiao requested a review from vdutor December 13, 2021 14:16
@ltiao ltiao marked this pull request as ready for review December 13, 2021 14:16
Copy link
Member

@vdutor vdutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just left a few minor comments to further improve the code quality.

@ltiao ltiao merged commit 26e5640 into develop Dec 15, 2021
@ltiao ltiao deleted the ltiao/basis-func-reorg branch December 15, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants