TF 2.5 compatibility #48
Conversation
… into vincent/tf25-cont
vdutor
force-pushed
the
vincent/tf25-cont
branch
from
0f90bcb
to
ec3acb5
Compare
.github/workflows/quality-check.yaml
Outdated
| tensorflow_probability: "~=0.12.0" | ||
| name: Python-${{ matrix.python-version }} tensorflow${{ matrix.tensorflow }} tensorflow_probability${{ matrix.tensorflow_probability }} | ||
| python-version: [3.6, 3.7, 3.8] | ||
| tensorflow: ["~=2.5"] |
There was a problem hiding this comment.
Should this be 2.5.0? I think this statement will install the latest minor version rather than the latest bugfix of 2.5.
|
|
||
| return decorator | ||
|
|
||
|
|
||
| class TrackableLayer(tf.keras.layers.Layer): |
There was a problem hiding this comment.
I like the idea of deferring actually removing this class until a later PR.
There was a problem hiding this comment.
Since you last reviewed the code, I added a deprecation message and a test (test_trackable_layer_is_removed_version_1_0_0) to make sure we remove TrackableLayer once we're at v1.0.0. Are you happy with those changes?
There was a problem hiding this comment.
Yes, that looks good.
| r""" | ||
| A :class:`tf.Layer` that tracks variables in :class:`tf.Module`\ s. | ||
|
|
||
| .. todo:: Once TensorFlow 2.5 is released, this class will be removed. |
There was a problem hiding this comment.
Should we keep the comment about removing the class entirely?
There was a problem hiding this comment.
Added deprecation message and a test test_trackable_layer_is_removed_version_1_0_0.
No description provided.