Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentence realizer is using default lexicon #3

Closed
vzam opened this issue Mar 10, 2023 · 1 comment
Closed

Sentence realizer is using default lexicon #3

vzam opened this issue Mar 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@vzam
Copy link

vzam commented Mar 10, 2023

Usually I am using the default lexicon but I was also wondering about a rather large memory footprint and found a possible issue here:
https://github.com/sebischair/SimpleNLG-DE/blob/843d14e8ec2d1d080e7e6da14e8b50b2d915f464/src/main/java/simplenlgde/syntax/ClauseHelper.java#LL59C16-L59C16

The default lexicon is being initialized for the realization of a clause, but I think the lexicon from the parent should be reused instead.
I didn't test it but this could also lead to a bug where default lexicon is not being used at all for clauses.

@DaBr01 DaBr01 closed this as completed Mar 10, 2023
@DaBr01
Copy link
Contributor

DaBr01 commented Mar 10, 2023

Oh wow, this is wild. Thanks for spotting it! I noticed it myself while fixing #2 but hadn't found yet where it happens. There it is. This cuts down realisiation time by a crazy factor.

@DaBr01 DaBr01 added the bug Something isn't working label Mar 10, 2023
DaBr01 added a commit that referenced this issue Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants