Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nalgebra to a safe version #281

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Conversation

dmweis
Copy link
Contributor

@dmweis dmweis commented Jun 11, 2021

Hey,

This bumps version of nalgebra to new version which should be safe from dimforge/nalgebra#883

I noticed issue mentioning that you don't have time to actively maintain this crate anymore so I figured I might save you some by just creating this PR myself even when it's a simple one.

I also saw that #280 exists but it seems that it missed updating the dev-dependencies

Testing

Since this crate doesn't have many tests I tested it by running the examples to make sure they work. I did this on a linux machine but I think it's pretty safe to assume that it doesn't break anything on other platforms.

@dmweis
Copy link
Contributor Author

dmweis commented Jun 11, 2021

I see that there is a failing test but it looks like it's failing on master as well

@karthikcl2590
Copy link

@dmweis are you planning to merge this?

@dmweis
Copy link
Contributor Author

dmweis commented Nov 5, 2021

@dmweis are you planning to merge this?

I will once it gets a review. But seems that this repo may be unmainted for now #277

@karthikcl2590
Copy link

Thanks for your response! It looks like @donkeyteethUX just stepped up to help maintain!
Also wonder if we could jump to a newer version while we're at it.

@donkeyteethUX donkeyteethUX self-requested a review November 8, 2021 18:31
Copy link
Collaborator

@donkeyteethUX donkeyteethUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmweis. Can you update to ncollide = 0.32 and nalgebra = 0.29 while we're at it?

@dmweis
Copy link
Contributor Author

dmweis commented Nov 8, 2021

Thanks @dmweis. Can you update to ncollide = 0.32 and nalgebra = 0.29 while we're at it?

Done! I left the patch versions unbound as as this is how it was originally. Let me know if you think we should lock to a specific version.

Builds and tests on ubuntu with x11 correctly. Examples run too. Sadly I don't have other platforms to test on.

@dmweis
Copy link
Contributor Author

dmweis commented Nov 8, 2021

Also thanks for joining this project as a maintainer @donkeyteethUX!

@karthikcl2590
Copy link

Seconded! Thanks to both of you :)

Copy link
Collaborator

@donkeyteethUX donkeyteethUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No issues with tests/examples on my linux machine.

@donkeyteethUX donkeyteethUX merged commit 23ae001 into sebcrozet:master Nov 9, 2021
@karthikcl2590
Copy link

@donkeyteethUX @dmweis it looks like the latest changes aren't pulled in via crates.io, i.e if my Cargo.toml looks like

[dependencies]
kiss3d = "0.31"

Are you planning to publish a new version?

@dmweis
Copy link
Contributor Author

dmweis commented Nov 11, 2021

If you need the fixed version right now you can tell cargo to pull it directly from github.

As long as you don't plan on publishing the package to crates.io that should be fine

@karthikcl2590
Copy link

Yep, I'm currently pointing Cargo to github (no plans on publishing to crates.io). Just wondering if a new kiss3d version is going to be published anytime soon.

@donkeyteethUX
Copy link
Collaborator

I bumped the package version to 0.32. @sebcrozet can you run cargo publish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants