Split sonarcloud analysis from build workflow #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build and Test (no longer sonar) Sonar analysis will now be executed only on master branch for security reasons
sebastienvermeille
force-pushed
the
14-sonarcloud-analysis-fail-on-external-contributor-prs
branch
from
8033d53
to
9d2c585
Compare
sebastienvermeille
deleted the
14-sonarcloud-analysis-fail-on-external-contributor-prs
branch
sebastienvermeille
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There is now two workflows:
Long story short: This split should allow to run sonar analysis for PR and branches (including forks) without giving access to SONAR_TOKEN secret as it is only executed on master branch (workflow_run)
The idea comes from here: https://community.sonarsource.com/t/how-to-use-sonarcloud-with-a-forked-repository-on-github/7363/32
How was it tested ?
Could not... need to be merged in master first 🤞
Relates to: