Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iteration in interop #967

Merged
merged 2 commits into from
Sep 25, 2021

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Sep 25, 2021

  • array-like when list or array should iterate values (like Set)
  • dictionary-likes should iterate keys and values (like Map)
  • IEnumerable behaves like custom Iterable added to regular JS object (enumerates values as-is)
  • any other object type is unsupported like in normal JS (like basic objects { "A": 1 })

@lahma lahma added the interop label Sep 25, 2021
@lahma lahma force-pushed the fix-interop-iteration-behavior branch from 5bb31d9 to 6b86b06 Compare September 25, 2021 09:25
@sebastienros
Copy link
Owner

Not the easiest of changes.

@sebastienros sebastienros merged commit 7e0b575 into sebastienros:main Sep 25, 2021
@lahma lahma deleted the fix-interop-iteration-behavior branch September 25, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants