Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing NewTarget handling for basic types #875

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Fix missing NewTarget handling for basic types #875

merged 1 commit into from
Apr 21, 2021

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Apr 21, 2021

  • fix OrdinaryCreateFromConstructor cases mentioned in spec
  • fix error constructor names

fixes #873

@lahma lahma requested a review from sebastienros April 21, 2021 14:10
sebastienros
sebastienros reviewed Apr 21, 2021
View reviewed changes
Copy link
Owner

@sebastienros sebastienros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there some new tests we can enable?

@lahma
Copy link
Collaborator Author

lahma commented Apr 21, 2021

Are there some new tests we can enable?

Unfortunately I was not able to find any specific ones. They pop up with the new features. Might be a different case with the new test suite (Jint's is years old).

@lahma lahma merged commit 170c72c into sebastienros:dev Apr 21, 2021
@lahma lahma deleted the fix-new-targets branch April 21, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"constructor" property is not set correctly for class instances
2 participants
@lahma @sebastienros