New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide engine instance when customizing options #751

Merged

sebastienros merged 2 commits into sebastienros:dev from lahma:provide-engine-when-setting-options

Jun 26, 2020

Collaborator

lahma commented Jun 23, 2020

engine instance - options - pair is provided as overload for engine construction
added shorthand to add converter just with generic parameter
remove options.DiscardGlobal, it doesn't make much sense and it isn't that expensive to create the global object, a lot of things rely on that anyway

fixes #310
fixes #655

lahma added 2 commits

June 23, 2020 20:10


          Provide engine instance when customizing options

05d8048


          remove DiscardGlobal

d988e06

sebastienros merged commit 69c525c into sebastienros:dev

lahma deleted the provide-engine-when-setting-options branch

October 31, 2021 07:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment