-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #615 improve engine creation performance #625
fixes #615 improve engine creation performance #625
Conversation
I think it should be a huge gain for ravendb also. Will benchmark it on Orchard tomorrow, because we don't even use all these objects. |
7eb11d9
to
1b03d8c
Compare
@sebastienros did you ever find the time to compare performance in Orchard? |
I remember I checked and it was faster but don't recall the numbers. |
Great, thanks for the update 🙂 |
if you like perf, there is so much to do in Orchard. It's allocating like crazy, which is not surprising because it does stuff ;) but which also means there are many ways to improve it. |
Maybe at some point, probably requires quite a lot studying to understand hot paths and important scenarios... |
@@ -59,32 +80,35 @@ public sealed class Engine | |||
internal readonly ArgumentsInstancePool _argumentsInstancePool; | |||
internal readonly JsValueArrayPool _jsValueArrayPool; | |||
|
|||
public ITypeConverter ClrTypeConverter; | |||
public readonly ITypeConverter ClrTypeConverter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this done? It is now no longer possible to override with a custom ITypeConverter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an oversight. Maybe submit a PR with a test case that protects from happening again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #654 for pr
Before
After