Harmonize exception throwing #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
perf/harmonize-exception-throwing
branch
from
8293b1a
to
d1557cc
Compare
lahma
force-pushed
the
perf/harmonize-exception-throwing
branch
from
d1557cc
to
cb5c8da
Compare
| @@ -717,13 +722,7 @@ public void PutValue(Reference reference, JsValue value) | |||
| else | |||
| { | |||
| var baseValue = reference.GetBase(); | |||
| if (!(baseValue is EnvironmentRecord record)) | |||
There was a problem hiding this comment.
I assume that if there is this test it's because it was in the spec. Maybe there is not code path for it, but I wouldn't remove it, unless you found out it could never be true.
There was a problem hiding this comment.
But as you can see the code right after it does forced cast so the invariant is present. It just changes from ambiguous ArgumentNullException to maybe even better InvalidCastException?
There was a problem hiding this comment.
Sorry, I thought it was throwing a JS exception. It's just dotnet one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly about cleanup and making exception throwing consistent. Now there's ExceptionHelper that does most of the throwing. This will also add possibility for JIT to inline better as there are no throw statements in function bodies.