Introduce IPropertyDescriptor and specialized descriptors #461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes PropertyDescriptor usage to happen through IPropertyDescriptor interface. This allows specialized descritors that don't hold other instance fields other than the actual JsValue. This benefits especially arrays where descriptor stays quite constant. Array heave operators seem to get around 10% allocation reduction.
ObjectInstance converts to more memory hungry full PropertyDescriptor when changes are requested. I've kept new specialized versions as internal. This change affects memory usage and should not have much positive or negative impact on speed. Virtual dispatch is already happening with PropertyDescriptor.Value as it's virtual.
Before
After