Make ObjectInstance MruPropertyCache2 dictionary lazy #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
perf/lazy-mru-cache
branch
from
c752307
to
2668661
Compare
|
I am currently refactoring all the Environment classes and ObjectInstance to follow the ES6 spec, this will give me some headache when I merge 🚑 |
|
What if you rebase overwriting with your changes and we re-implement the ObjectInstance part later if there's a TODO comment? |
|
Don't worry, I'll make it work. |
lahma
force-pushed
the
perf/lazy-mru-cache
branch
2 times, most recently
from
1316633
to
fdf76db
Compare
* remove LINQ from hot paths * use List<T> where possible to get rid of memory allocations * cache empty completions
* use separate fields for commonly accessed prototype and constructor
* this helps with array optimization branch as this can be considered master version
lahma
force-pushed
the
perf/lazy-mru-cache
branch
from
fdf76db
to
1a9b3d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add commonly accessed prototype and constructor fields directly to ObjectInstance. Dictionary is initialized if these two fields are not enough to describe the object. On top of memory usage changes so that PR needs to be addressed first.