Add tests for using modules from script code run via Evaluate#2712
Merged
Conversation
Covers the patterns discussed in sebastienros#1472: dynamic import() inside a classic script (both .then and await forms) resolving modules registered via Modules.Add without EnableModules, and exposing an imported module namespace as a global for Evaluate-based code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lahma
enabled auto-merge (squash)
July 20, 2026 17:55
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for the patterns that answer discussion #1472 ("Cannot use import/export statements outside a module" — how to use modules from code run via
Evaluate):CanDynamicallyImportFromScriptCode— dynamicimport()inside a classic script resolves modules registered viaModules.Add, withoutEnableModulesor a script source location. This path had no coverage; existing script-side dynamic import tests all use custom module loaders with explicitsource:parameters.CanAwaitDynamicImportFromScriptCode— same viaawait import()in an async IIFE.CanExposeModuleNamespaceToScriptCode— importing a module from .NET and exposing its namespace object as a global forEvaluate-based code.No production code changes.
Test plan
dotnet test --configuration Release Jint.Tests --filter "FullyQualifiedName~Jint.Tests.Runtime.ModuleTests"— 57 passed (net10.0 and net472)🤖 Generated with Claude Code