Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Jint.Tests/Runtime/ProxyTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,24 @@ public void ProxyCanBeRevokedWithoutContext()
");
}

[Fact]
public void GetTrapIsCalledForPropertyNamedRevoke()
{
Assert.Equal("trapped", _engine.Evaluate("new Proxy({}, { get: () => 'trapped' }).revoke").AsString());
}

[Fact]
public void AccessingPropertyOnRevokedProxyThrowsTypeError()
{
_engine.Execute(@"
var revocable = Proxy.revocable({ foo: 1 }, { get: () => 'trapped' });
var proxy = revocable.proxy;
revocable.revoke();
");
var ex = Assert.Throws<JavaScriptException>(() => _engine.Evaluate("proxy.foo"));
AssertJsTypeError(_engine, ex, "Cannot perform 'foo' on a proxy that has been revoked");
}

[Fact]
public void ProxyToStringUseTarget()
{
Expand Down
3 changes: 1 addition & 2 deletions Jint/Native/JsProxy.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ internal sealed class JsProxy : ObjectInstance, IConstructor, ICallable
private static readonly JsString TrapOwnKeys = new JsString("ownKeys");
private static readonly JsString TrapConstruct = new JsString("construct");

private static readonly JsString KeyFunctionRevoke = new JsString("revoke");
private static readonly JsString KeyIsArray = new JsString("isArray");

public JsProxy(
Expand Down Expand Up @@ -129,7 +128,7 @@ public override JsValue Get(JsValue property, JsValue receiver)
AssertTargetNotRevoked(property);
var target = _target;

if (KeyFunctionRevoke.Equals(property) || !TryCallHandler(TrapGet, [target, TypeConverter.ToPropertyKey(property), receiver], out var result))
if (!TryCallHandler(TrapGet, [target, TypeConverter.ToPropertyKey(property), receiver], out var result))
{
return target.Get(property, receiver);
}
Expand Down
Loading