Skip to content

Build the yield argument handler once, not per evaluation #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 1 commit into from
Jul 6, 2026
Merged

Build the yield argument handler once, not per evaluation #2593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Jint/Runtime/Interpreter/Expressions/JintYieldExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ namespace Jint.Runtime.Interpreter.Expressions;

internal sealed class JintYieldExpression : JintExpression
{
private readonly JintExpression? _argument;

public JintYieldExpression(YieldExpression expression) : base(expression)
{
_argument = expression.Argument is not null ? Build(expression.Argument) : null;
}

protected override object EvaluateInternal(EvaluationContext context)
Expand Down Expand Up @@ -171,9 +174,9 @@ protected override object EvaluateInternal(EvaluationContext context)

// Normal yield: evaluate argument and yield the value
JsValue value;
if (expression.Argument is not null)
if (_argument is not null)
{
value = Build(expression.Argument).GetValue(context);
value = _argument.GetValue(context);

// If the argument evaluation suspended the generator (nested yield), propagate
// the suspension up without yielding again - the inner yield already suspended
Expand Down
Loading