Skip to content

Fix flag v bugs in custom regex engine#2481

Merged
lahma merged 1 commit into
sebastienros:mainfrom
adams85:regexp-fixes-2
May 18, 2026
Merged

Fix flag v bugs in custom regex engine#2481
lahma merged 1 commit into
sebastienros:mainfrom
adams85:regexp-fixes-2

Conversation

@adams85

@adams85 adams85 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR makes some minor corrections to the custom regexp engine failing to execute some valid regexp patterns.

Details

The custom engine incorrectly rejects some regexp constructs in flag v patterns:

Linked issue

n/a

Test plan

  • Added or updated unit tests in Jint.Tests
  • Ran dotnet test --configuration Release locally
  • For ECMAScript spec changes: ran Jint.Tests.Test262 and confirmed no regressions
  • For interop changes: covered in Jint.Tests/Runtime/Interop
  • For perf changes: included before/after numbers from Jint.Benchmark

Breaking change?

No

…racter outside class sets and escaped ClassSetReservedPunctuator inside class sets in flag v mode

@lahma lahma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you as always!

@lahma
lahma merged commit 124afc0 into sebastienros:main May 18, 2026
4 checks passed
@adams85

adams85 commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

My pleasure :)

BTW, working on another one, so more to come soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants