Fix MemoryLimitConstraint skipping check when async resumes on a different thread#2480
Merged
lahma merged 1 commit intoMay 17, 2026
Merged
Conversation
…erent thread GC.GetAllocatedBytesForCurrentThread() is per-thread, so comparing the counter captured in Reset() with the one read in Check() is meaningless when an async continuation resumes on a different thread pool thread. This can silently bypass the limit or produce false positives. Store the thread ID in Reset() and skip the check in Check() when the current thread differs from the one that called Reset(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lahma
force-pushed
the
fix/memory-limit-async-thread
branch
from
May 17, 2026 16:45
35fbbbc to
8023bcd
Compare
lahma
enabled auto-merge (squash)
May 17, 2026 16:46
lahma
disabled auto-merge
May 17, 2026 16:48
lahma
enabled auto-merge (squash)
May 17, 2026 16:48
This was referenced May 18, 2026
This was referenced Jun 4, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GC.GetAllocatedBytesForCurrentThread() is per-thread. When an async continuation resumes on a different thread pool thread, Reset() and Check() read counters from different threads, which can silently bypass the limit or produce false positives.
Fix: store the ManagedThreadId in Reset() and skip the check in Check() when the current thread differs. Safe degradation: the constraint is not enforced across thread hops, but no wrong results are produced.