Serialize Atomics.waitAsync test262 group instead of excluding it#2479
Merged
Conversation
Test262Harness 1.0.6 (lahma/test262-harness-dotnet#142) adds NonParallel{Features,Flags,Files} options that emit [NonParallelizable] on selected generated test methods, overriding the inherited [Parallelizable(ParallelScope.All)]. Use it here for the Atomics.waitAsync suite: previously the no-spurious-wakeup-on- exchange.js case was excluded wholesale because Task.Delay-driven timeout resolution on loaded Windows runners can fire a few ms shy of the requested $262.agent.timeouts.small (200ms), tripping the lapse >= TIMEOUT assertion when the test ran alongside other CPU- bound suites. Serialising the whole Atomics_WaitAsync group is a softer fix that restores test coverage of the previously-disabled case while keeping the rest of the suite parallel. Bump Test262Harness package and the test262harness.console tool manifest to 1.0.6 so the generator emits the new attribute. Verified [NonParallelizable] lands on exactly the two generated methods (Atomics/waitAsync root and bigint subdir) and nowhere else. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
lahma
enabled auto-merge (squash)
May 17, 2026 09:30
This was referenced May 18, 2026
This was referenced Jun 4, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test262Harnesspackage +test262harness.consoletool manifest from 1.0.5/1.0.4 to 1.0.6, which introduces theNonParallel{Features,Flags,Files}settings (see Add NonParallel* options to emit [NonParallelizable] on selected tests lahma/test262-harness-dotnet#142). Matches emit[NonParallelizable]on the generated NUnit method, overriding the inherited[Parallelizable(ParallelScope.All)]."NonParallelFeatures": ["Atomics.waitAsync"]to serialise the whole Atomics.waitAsync test group rather than excluding individual timing-sensitive cases. This restores coverage ofbuilt-ins/Atomics/waitAsync/no-spurious-wakeup-on-exchange.js, which was disabled in f71c1ba becauseTask.Delay-driven timeout resolution on loaded Windows runners can complete a few ms shy of the requested$262.agent.timeouts.small(200ms), tripping thelapse >= TIMEOUTassertion when the test ran alongside other CPU-bound suites.Verification
Regenerated suite after the bump:
[NonParallelizable]appears on exactly two generated methods —Atomics/waitAsyncroot and thebigintsubdirectory variant — and nowhere else inbuilt-ins/annexB/intl402/language.built-ins/Atomics/waitAsync/no-spurious-wakeup-on-exchange.jsis back in the suite (TestCaselines for both strict and non-strict modes).Test plan
🤖 Generated with Claude Code