Stabilize pre-1970 setYear test#2464
Merged
Merged
Conversation
## Summary Pin the pre-1970 setYear test to UTC. ## Details - Run ShouldSetYearBefore1970 with an explicit UTC local timezone. - Avoid dependence on the machine default timezone when asserting the resulting ISO timestamp. - Leave runtime date behavior unchanged; this is a test-only stability fix. ## Linked issue Refs # ## Test plan - [x] Added or updated unit tests in Jint.Tests - [ ] Ran dotnet test --configuration Release locally - [ ] For ECMAScript spec changes: ran Jint.Tests.Test262 and confirmed no regressions - [ ] For interop changes: covered in Jint.Tests/Runtime/Interop - [ ] For perf changes: included before/after numbers from Jint.Benchmark Additional local validation: - dotnet test Jint.Tests/Jint.Tests.csproj --filter "FullyQualifiedName~EngineTests.ShouldSetYearBefore1970" ## Breaking change? No.
lahma
approved these changes
May 14, 2026
lahma
enabled auto-merge (squash)
May 14, 2026 07:11
This was referenced May 18, 2026
This was referenced Jun 4, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the pre-1970 setYear test to UTC.
Details
Linked issue
Refs #
Test plan
Additional local validation:
Breaking change?
No.