Skip to content

Skip GetParameters call if target method is not generic. #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 1 commit into from
Apr 7, 2026
Merged

Skip GetParameters call if target method is not generic. #2387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Jint/Runtime/Interop/MethodInfoFunction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,11 @@ static JsCallArguments ArgumentProvider(MethodDescriptor method, MethodResolverS

var argumentsMatch = true;
var resolvedMethod = ResolveMethod(method.Method, methodParameters, arguments);
// TPC: if we're concerned about cost of MethodInfo.GetParameters() - we could only invoke it if this ends up being a generic method (i.e. they will be different in that scenario)
methodParameters = resolvedMethod.GetParameters();
// We only need to call GetParameters it if this ends up being a generic method (i.e. they will be different in that scenario)
if (resolvedMethod.IsGenericMethod)
{
methodParameters = resolvedMethod.GetParameters();
}
for (var i = 0; i < parameters.Length; i++)
{
var methodParameter = methodParameters[i];
Expand Down