Skip to content

Update Acornima to 1.3.2 #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 1 commit into from
Apr 3, 2026
+12 −33
Merged

Update Acornima to 1.3.2 #2374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Acornima" Version="1.3.1" />
<PackageVersion Include="Acornima.Extras" Version="1.3.1" />
<PackageVersion Include="Acornima" Version="1.3.2" />
<PackageVersion Include="Acornima.Extras" Version="1.3.2" />
<PackageVersion Include="BenchmarkDotNet" Version="0.15.8" />
<PackageVersion Include="BenchmarkDotNet.TestAdapter" Version="0.13.12" />
<PackageVersion Include="FluentAssertions" Version="[7.2.2]" />
Expand Down
29 changes: 1 addition & 28 deletions Jint.Tests.Test262/Test262Harness.settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@
"language/identifiers/*-unicode-16.*.js",
"language/identifiers/*-unicode-17.*.js",

// Acornima parsing limitations
"language/statements/await-using/syntax/await-using-valid-for-await-using-of-of.js",
"language/statements/using/syntax/using-for-statement.js",

// Currently quite impossible to detect if assignment target is CoverParenthesizedExpression
"language/expressions/assignment/fn-name-lhs-cover.js",

Expand Down Expand Up @@ -363,32 +359,9 @@

// === ANNEX B EXCLUSIONS ===

// Acornima parser limitation: assignment target type validation for call expressions
// Per B.3.7, non-strict mode should allow CallExpression as assignment target in certain cases
// Requires Acornima AllowCallExpressionAsLhs option (pending upstream PR)
"annexB/language/expressions/assignmenttargettype/callexpression-as-for-in-lhs.js",
"annexB/language/expressions/assignmenttargettype/callexpression-as-for-of-lhs.js",
"annexB/language/expressions/assignmenttargettype/callexpression-in-compound-assignment.js",
"annexB/language/expressions/assignmenttargettype/callexpression-in-postfix-update.js",
"annexB/language/expressions/assignmenttargettype/callexpression-in-prefix-update.js",
"annexB/language/expressions/assignmenttargettype/callexpression.js",
"annexB/language/expressions/assignmenttargettype/cover-callexpression-and-asyncarrowhead.js",

// Acornima parser/RegExp limitation: malformed named groups in non-unicode mode
// Per B.1.2, non-unicode RegExp should accept some malformed named group syntax
"annexB/built-ins/RegExp/named-groups/non-unicode-malformed.js",

// Acornima parser limitation: using/await-using in single-statement positions not rejected
// Fix pending: https://github.com/adams85/acornima/pull/32
"language/statements/await-using/syntax/await-using-invalid-for-in.js",
"language/statements/await-using/syntax/with-initializer-do-statement-while-expression.js",
"language/statements/await-using/syntax/with-initializer-for-statement.js",
"language/statements/await-using/syntax/with-initializer-if-expression-statement.js",
"language/statements/await-using/syntax/with-initializer-if-expression-statement-else-statement.js",
"language/statements/await-using/syntax/with-initializer-label-statement.js",
"language/statements/await-using/syntax/with-initializer-while-expression-statement.js",
"language/statements/using/syntax/using-invalid-for-in.js",
"language/statements/using/syntax/with-initializer-for-statement.js"
"annexB/built-ins/RegExp/named-groups/non-unicode-malformed.js"

]
}
2 changes: 1 addition & 1 deletion Jint/Runtime/Interpreter/Expressions/JintUpdateExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ private JsValue UpdateNonIdentifier(EvaluationContext context)
var reference = _argument.Evaluate(context) as Reference;
if (reference is null)
{
Throw.TypeError(engine.Realm, "Invalid left-hand side expression");
Throw.ReferenceError(engine.Realm, "Invalid left-hand side in assignment");
}

reference.AssertValid(engine.Realm);
Expand Down
10 changes: 8 additions & 2 deletions Jint/Runtime/Interpreter/Statements/JintForInForOfStatement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ private void InitializeLhs(
expr = new JintMemberExpression(memberExpression);
break;
default:
expr = new JintIdentifierExpression((Identifier) _leftNode);
expr = _leftNode is Expression expression
? JintExpression.Build(expression)
: new JintIdentifierExpression((Identifier) _leftNode);
break;
}
}
Expand Down Expand Up @@ -463,7 +465,11 @@ private Completion BodyEvaluation(
}
else
{
var reference = (Reference) lhsRef;
var reference = lhsRef as Reference;
if (reference is null)
{
Throw.ReferenceError(engine.Realm, "Invalid left-hand side in assignment");
}
if (lhsKind == LhsKind.LexicalBinding || _leftNode.Type == NodeType.Identifier && !reference.IsUnresolvableReference)
{
reference.InitializeReferencedBinding(nextValue, _disposeHint);
Expand Down