Add public IsCallable() and IsConstructor() extension methods#2371
Merged
Conversation
…ienros#2338) Expose IsCallable and IsConstructor as public extension methods on JsValue, completing the public type-checking API surface alongside existing methods like IsArray, IsDate, IsPromise, etc. Closes sebastienros#2338 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lahma
enabled auto-merge (squash)
March 26, 2026 16:44
This was referenced Mar 27, 2026
This was referenced Jun 8, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsCallable()andIsConstructor()public extension methods onJsValue, closing the gap in the public type-checking API (Can't check if a JsValue is a function #2338)IsArray(),IsDate(),IsPromise(), etc. extension methodsIsCallable/IsConstructorproperties — no internal changes neededTest plan
PublicInterfaceTestscovering positive and negative cases for both methodsnet10.0andnet472target frameworks🤖 Generated with Claude Code