Skip to content

Always enable modules in Jint.Repl for dynamic import#2356

Merged
lahma merged 1 commit into
sebastienros:mainfrom
ivankra:dynamic-import
Mar 24, 2026
Merged

Always enable modules in Jint.Repl for dynamic import#2356
lahma merged 1 commit into
sebastienros:mainfrom
ivankra:dynamic-import

Conversation

@ivankra

@ivankra ivankra commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Dynamic import can be used even if the script itself is not a module. There are about 50 such tests in test262 that would previously fail with "Module loading has been disabled, you need to enable it in engine options" e.g. test/language/expressions/dynamic-import/always-create-new-promise.js

Dynamic import can be used even if the script itself is not a module.
There are about 50 such tests in test262 that would previously fail with
"Module loading has been disabled, you need to enable it in engine options"
e.g. test/language/expressions/dynamic-import/always-create-new-promise.js

@lahma lahma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lahma
lahma merged commit 07f1047 into sebastienros:main Mar 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants