Fix Temporal calendar handling and enable 2,782 more test262 passes#2347
Merged
Conversation
…jection (+2,782 test262 passes) - Route buddhist/roc/japanese through CalendarDateToISO in PlainDateTime/ZonedDateTime/PlainYearMonth with() - Add CalendarDayOfYear helper for non-ISO calendar day-of-year computation - Reject islamic/islamic-rgsa calendars in Temporal from() constructors (observation-based) - Add missing era/eraYear field reading in ZonedDateTime.prototype.with() - Fix month/monthCode priority in non-ISO with() (pass month=0 when monthCode explicit) - Fix single-era calendars (coptic, hebrew, persian, indian, ethioaa) to always return primary era - Accept "ad"/"bc" as era code aliases for "ce"/"bce" in Japanese calendar - Fix Japanese Meiji era: ComputeYearFromEra offset (1867), display boundary (year >= 1873) - Fix invalid monthCode rejection (M14 for coptic, M13 for 12-month calendars) - Consolidate monthCode validation into ValidateMonthCodeForNonLeapCalendar helper Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lahma
enabled auto-merge (squash)
March 22, 2026 14:46
lahma
disabled auto-merge
March 22, 2026 14:52
lahma
enabled auto-merge (squash)
March 22, 2026 14:52
This was referenced Mar 23, 2026
This was referenced Jun 8, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with()for Gregorian-based calendars (buddhist/roc/japanese) in PlainDateTime, ZonedDateTime, PlainYearMonth — route throughCalendarDateToISOinstead of treating calendar year as ISO yeardayOfYearfor non-ISO calendars — return calendar-aware day-of-year instead of ISO day-of-yearislamic/islamic-rgsacalendars in Temporalfrom()constructors (observation-based, not supported for arithmetic)ZonedDateTime.prototype.with()with()— whenmonthCodeis explicitly provided butmonthis not, avoid conflict with defaulted month valuead/bcas era code aliases force/bcein Japanese calendareraYear + 1867), display boundary (year >= 1873), and year-level boundary (no day-level check for Meiji)ValidateMonthCodeForNonLeapCalendarhelperBefore: 93,206 test262 passes, ~343 excluded intl402/Temporal files
After: 95,988 test262 passes, 215 excluded intl402/Temporal files (+2,782 passes, 128 fewer exclusions)
Test plan
dotnet test --configuration Release Jint.Tests.Test262/Jint.Tests.Test262.csproj— 95,988 passed, 0 faileddotnet test --configuration Release Jint.Tests/Jint.Tests.csproj— 2,764 passed, 0 failed🤖 Generated with Claude Code