Fix locale-specific date separators in DateTimeFormat#2319
Merged
Conversation
toLocaleDateString was using hardcoded "/" separator for all numeric
date formats. Now derives both date component order and separator from
the locale's ShortDatePattern via DateTimeFormatInfo, fixing output for
locales like nl-NL (should use "-"), de-DE ("."), sv-SE ("-"), etc.
Also uses useUserOverride: false when creating CultureInfo to ensure
consistent behavior regardless of Windows regional settings.
Fixes sebastienros#557
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lahma
enabled auto-merge (squash)
March 6, 2026 16:55
This was referenced Mar 7, 2026
This was referenced Jun 8, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #557 (comment: #557 (comment))
toLocaleDateStringwas using hardcoded"/"separator for all numeric date formats. Now derives both the date component order and separator from the locale'sShortDatePatternviaDateTimeFormatInfo. This fixes output for locales likenl-NL(uses-),de-DE(.),sv-SE(-),ko-KR(.), etc.sv-SE(YMD). Now parses the order fromShortDatePattern.useUserOverride: falsewhen creatingCultureInfoto ensure consistent behavior regardless of the host's Windows regional settings.Before / After
6-3-20266/3/20266-3-20265.3.20265/3/20265.3.20262026-03-055/3/20262026-03-052026. 3. 5.2026/3/52026. 3. 5.Test plan
ParseDateOrderlogic produces correct order for 12+ locales🤖 Generated with Claude Code