Fix module-graphs-does-not-hang and import abrupt return test262 failures#2316
Merged
Conversation
…est262 failures - Set _asyncEvaluation = false in AsyncModuleExecutionFulfilled execList loop per spec step 12.c.iii, preventing dynamic import() from treating already- evaluated modules as having pending async dependencies - Add IsGeneratorAborted() checks in JintImportExpression after evaluating specifier and options, so import() bails out on generator.return() - Track sequence expression suspension index via SequenceSuspendData to skip already-evaluated sub-expressions on generator resume (avoiding duplicate side effects) - Add IsGeneratorAborted() check in JintSequenceExpression to stop evaluation when generator return is requested Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lahma
enabled auto-merge (squash)
March 6, 2026 15:35
This was referenced Mar 7, 2026
This was referenced Jun 8, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_asyncEvaluation = falsein theexecListloop per spec step 12.c.iii, fixing TLA module graphs where dynamicimport()never settles because already-evaluated modules retain stale async stateIsGeneratorAborted()checks after evaluating specifier/options soimport()bails out whengenerator.return()is called viayieldSequenceSuspendDatato skip already-evaluated sub-expressions on generator resume (preventing duplicate side effects), and addIsGeneratorAborted()to stop evaluation on generator returnRemoves test262 exclusions for
module-graphs-does-not-hang.jsand2nd-param-evaluation-abrupt-return.js(+3 newly passing test cases, 0 regressions across 92,218 tests).Test plan
dotnet test --filter "module-graphs-does-not-hang"— passes (1 case)dotnet test --filter "2nd-param-evaluation-abrupt-return"— passes (2 cases: strict + sloppy)dotnet test --filter "top-level-await"— 253 passed, 0 faileddotnet test --filter "dynamic-import"— 1,129 passed, 0 failed🤖 Generated with Claude Code