Fix InvalidCastException when a property getter is a bound function#2301
Merged
Conversation
Co-authored-by: lahma <171892+lahma@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix InvalidCastException for BindFunction in object getter
Fix InvalidCastException when a property getter is a bound function
Mar 1, 2026
lahma
marked this pull request as ready for review
March 1, 2026 10:06
lahma
approved these changes
Mar 1, 2026
This was referenced Mar 2, 2026
This was referenced Jun 8, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectInstance.UnwrapFromGetterandPrivateGetboth cast the getter directly toFunction.Function, butBindFunctionextendsObjectInstancedirectly (notFunction) and only implementsICallable. This causes anInvalidCastExceptionwhen accessing a property whose getter was created via.bind().Changes
ObjectInstance.UnwrapFromGetter: Replace direct(Function.Function)cast withICallable. Route the call throughengine.Call(callable, thisObject, Arguments.Empty, null)(engine accessed via(ObjectInstance)getter) — this handles all callable types (BindFunction,JsProxy, etc.) while preserving call-stack management required by the debugger.ObjectInstance.PrivateGet: Same fix; uses the already-available_engineinstance field.FunctionTests: Add regression testBoundFunctionCanBeUsedAsPropertyGetter.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.