Fix CLR toJSON method invocation in JSON.stringify#2292
Merged
Conversation
…pper Co-authored-by: lahma <171892+lahma@users.noreply.github.com>
…e it non-enumerable Co-authored-by: lahma <171892+lahma@users.noreply.github.com>
Co-authored-by: lahma <171892+lahma@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CLR class with toJSON method causing JavaScriptException
Fix CLR toJSON method invocation in JSON.stringify
Feb 17, 2026
lahma
marked this pull request as ready for review
February 17, 2026 20:55
lahma
approved these changes
Feb 17, 2026
This was referenced Mar 2, 2026
This was referenced Jun 8, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLR classes with
toJSONmethods threw "No public methods with the specified arguments were found" when serialized viaJSON.stringify. JSON.stringify callstoJSON()with no arguments, but the CLR method was exposed asMethodInfoFunctionwhich failed to match the signature.Changes
toJSONinstance methods during type analysistoJSONasClrFunctionin constructor, following the same pattern aslength/disposespecial propertiesDate.prototype.toJSONbehavior)Example
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.