Skip to content

Enable Temporal related internalization API tests and fix issues #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 2 commits into from
Feb 12, 2026
Merged

Enable Temporal related internalization API tests and fix issues #2277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1265bc2
Fix some Temporal related internationalization API issues
lahma Feb 8, 2026
6109a62
fix
lahma Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 6 additions & 53 deletions Jint.Tests.Test262/IcuCldrProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,67 +271,20 @@ private static string MapToCldrUnit(string unit)
public DateTimePatterns? GetDateTimePatterns(string locale, string? dateStyle, string? timeStyle)
=> _fallback.GetDateTimePatterns(locale, dateStyle, timeStyle);

public string[]? GetMonthNames(string locale, string style)
=> _fallback.GetMonthNames(locale, style);
public string[]? GetMonthNames(string locale, string style, string? calendar)
=> _fallback.GetMonthNames(locale, style, calendar);

public string[]? GetWeekdayNames(string locale, string style)
=> _fallback.GetWeekdayNames(locale, style);

public string[]? GetDayPeriods(string locale, string style)
=> _fallback.GetDayPeriods(locale, style);
public string[]? GetDayPeriods(string locale, string style, string? calendar)
=> _fallback.GetDayPeriods(locale, style, calendar);

public string[]? GetEraNames(string locale, string style)
=> _fallback.GetEraNames(locale, style);
public string[]? GetEraNames(string locale, string style, string? calendar)
=> _fallback.GetEraNames(locale, style, calendar);

// === Display Names ===

public string? GetLanguageDisplayName(string locale, string code)
{
try
{
var displayLocale = new UCultureInfo(locale);
var codeLocale = new UCultureInfo(code);
var result = codeLocale.GetDisplayLanguage(displayLocale);
return string.IsNullOrEmpty(result) ? _fallback.GetLanguageDisplayName(locale, code) : result;
}
catch
{
return _fallback.GetLanguageDisplayName(locale, code);
}
}

public string? GetRegionDisplayName(string locale, string code)
{
try
{
var displayLocale = new UCultureInfo(locale);
// Create a locale with just the region
var codeLocale = new UCultureInfo("und-" + code);
var result = codeLocale.GetDisplayCountry(displayLocale);
return string.IsNullOrEmpty(result) ? _fallback.GetRegionDisplayName(locale, code) : result;
}
catch
{
return _fallback.GetRegionDisplayName(locale, code);
}
}

public string? GetScriptDisplayName(string locale, string code)
{
try
{
var displayLocale = new UCultureInfo(locale);
// Create a locale with just the script
var codeLocale = new UCultureInfo("und-" + code);
var result = codeLocale.GetDisplayScript(displayLocale);
return string.IsNullOrEmpty(result) ? _fallback.GetScriptDisplayName(locale, code) : result;
}
catch
{
return _fallback.GetScriptDisplayName(locale, code);
}
}

public string? GetCurrencyDisplayName(string locale, string code)
=> _fallback.GetCurrencyDisplayName(locale, code);

Expand Down
1 change: 1 addition & 0 deletions Jint.Tests.Test262/Jint.Tests.Test262.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
<PackageReference Include="ICU4N" />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="Newtonsoft.Json" />
<PackageReference Include="NodaTime" />
<PackageReference Include="NUnit" />
<PackageReference Include="NUnit3TestAdapter" />
<PackageReference Include="Test262Harness" />
Expand Down
Loading