Skip to content

Add Intl.NumberFormat and update toLocaleString #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 2 commits into from
Jan 24, 2026
Merged

Add Intl.NumberFormat and update toLocaleString #2258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca4ed61
feat(intl): Add Intl.NumberFormat and update toLocaleString
lahma Jan 24, 2026
87f5da1
Merge branch 'main' into intl-pr6-number-format
lahma Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Jint/Native/BigInt/BigIntPrototype.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.Globalization;
using System.Numerics;
using System.Text;
using Jint.Native.Intl;
using Jint.Native.Object;
using Jint.Native.Symbol;
using Jint.Runtime;
Expand Down Expand Up @@ -53,9 +54,12 @@ private JsValue ToLocaleString(JsValue thisObject, JsCallArguments arguments)
var options = arguments.At(1);

var x = ThisBigIntValue(thisObject);
//var numberFormat = (NumberFormat) Construct(_realm.Intrinsics.NumberFormat, new[] { locales, options });
// numberFormat.FormatNumeric(x);
return x._value.ToString("R", CultureInfo.InvariantCulture);

// Use Intl.NumberFormat for locale-aware formatting
var numberFormat = (JsNumberFormat) Engine.Realm.Intrinsics.NumberFormat.Construct([locales, options], Engine.Realm.Intrinsics.NumberFormat);

// Use BigInteger overload to avoid precision loss
return numberFormat.Format(x._value);
}

/// <summary>
Expand Down
1 change: 1 addition & 0 deletions Jint/Native/Intl/IntlInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ protected override void Initialize()
{
["Collator"] = new(_realm.Intrinsics.Collator, PropertyFlags),
["Locale"] = new(_realm.Intrinsics.Locale, PropertyFlags),
["NumberFormat"] = new(_realm.Intrinsics.NumberFormat, PropertyFlags),
["PluralRules"] = new(_realm.Intrinsics.PluralRules, PropertyFlags),
["getCanonicalLocales"] = new(new ClrFunction(Engine, "getCanonicalLocales", GetCanonicalLocales, 1, PropertyFlag.Configurable), PropertyFlags),
["supportedValuesOf"] = new(new ClrFunction(Engine, "supportedValuesOf", SupportedValuesOf, 1, PropertyFlag.Configurable), PropertyFlags),
Expand Down
Loading