Skip to content

Rewrite of flaky test #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 1 commit into from
Nov 9, 2025
Merged

Rewrite of flaky test #2195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Jint.Tests/Runtime/AsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System.Collections.Concurrent;
using Jint.Native;
using Jint.Runtime;
using Jint.Tests.Runtime.TestClasses;

namespace Jint.Tests.Runtime;
Expand Down Expand Up @@ -43,13 +44,14 @@ public void ShouldReturnedTaskConvertedToPromiseInJS()
}

[Fact]
public void ShouldUnwrapPromiseWithCustomTimeout()
public void ShouldRespectCustomProvidedTimeoutWhenUnwrapping()
{
Engine engine = new(options => options.ExperimentalFeatures = ExperimentalFeature.TaskInterop);
engine.SetValue("asyncTestClass", new AsyncTestClass());
var result = engine.Evaluate("asyncTestClass.ReturnDelayedTaskAsync().then(x=>x)");
result = result.UnwrapIfPromise(TimeSpan.FromMilliseconds(200));
Assert.Equal(AsyncTestClass.TestString, result);
var timeout = TimeSpan.FromMilliseconds(1);
var exception = Assert.Throws<PromiseRejectedException>(() => result.UnwrapIfPromise(timeout));
Assert.Equal($"Promise was rejected with value Timeout of {timeout} reached", exception.Message);
}

[Fact]
Expand Down