Ensure that relative imports from module import are module-relative#2033
Open
rmja wants to merge 1 commit intosebastienros:mainfrom
Open
Ensure that relative imports from module import are module-relative#2033rmja wants to merge 1 commit intosebastienros:mainfrom
rmja wants to merge 1 commit intosebastienros:mainfrom
Conversation
Author
|
Okay, I can see from the failing test that this is actually the intended behavior? |
Collaborator
|
Generally the test cases establish the current API contract so I guess this would be a breaking change, unless the old behavior can be considered incorrect. One option is to provide more extension points if needed so that you can achieve your goal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the Engine configuration with enabled modules:
where the contents of
/modules-directoryis:The content of the index file references the helper file is:
Note that the path to
./some-file.jsis relative to the index file.If we then do
Then when calling into
my-module, thesome-file.jsfile should be found from the/modules-directory/my-moduledirectory, and not from/modules-directory.