Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite default export from SourceTextModule #1952

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Don't overwrite default export from SourceTextModule #1952

merged 1 commit into from
Aug 21, 2024

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Aug 21, 2024

Before this JintExportDefaultDeclaration.ExecuteInternal always overwrites the probably existing binding from SourceTextModule.InitializeEnvironment.

@viceice
Copy link
Contributor Author

viceice commented Aug 21, 2024

@lahma I don't think the failed test is related to the PR changes. 🤔

lahma
lahma approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any harm in this change, thanks for investigating and fixing!

@lahma lahma enabled auto-merge (squash) August 21, 2024 19:35
@lahma lahma merged commit 2f3a801 into sebastienros:main Aug 21, 2024
3 checks passed
@viceice viceice deleted the fix/unnamed-default-export-functions branch August 21, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exporting a default function without name isn't possible
2 participants
@viceice @lahma