Fix throwing on accessing CLR FunctionDeclaration #1949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm open to finding a better solution to the problem described below, as the current fix has weird ergonomics.
Accessing
FunctionDeclaration
of aMethodInfoFunction
(CLR functions) currently throws - the test* included describes the scenario. I believe accessing the property should never throw (I hate linking to MSDN, alas: https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/property?redirectedfrom=MSDN).This forces a sprinkle of
!
in the codebase in places where we know the function is not a CLR function (this is the part I don't like).*I've included two tests now, one for the delegate, and one for the method info function.
Unrelated to this, for the debugger I'm working on, I'd need to make at least some information of
MethodInfoFunction
andDelegateWrapper
public to provide information about the native function (get the parameters, largely the same thing Jint does internally). This is outside of this PR's scope, just announcing ahead of time to discuss, should there be objections to that.This would be:
DelegateWrapper
:Delegate _d
MethodInfoFunction
:MethodDescriptor[] _methods
, possiblyClrFunction _fallbackClrFunctionInstance