Adding ArrayLikeWrapper to support more interop array operations #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is closer to what I had in mind. If you wish I can push commit(s) to this branch to tweak things. |
|
Yeah, absolutely! Go for it. |
|
I added you to the repository so you can push commits there if you like. |
|
Just an update, I made some progress with bit of a refining proposal, hopefully have some time coming days to finish. |
|
I've implemented some changes, all tests now green and also supports Newtonsoft array map operations that were failing earlier in OOTB experience because of problematic indexers. Custom configuration for non .NET 8 is now quite minimal. |
|
Looks great! |
|
Thanks for the PR, I think the approach now allows more customizations later, if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are failing tests, but this approach does have less reflection going on. What are your thoughts @lahma ?