Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interop against System.Text.Json types on NET8+ #1826

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Mar 31, 2024

On NET 8+ we can support reading and accessing STJ types without complex and hard to figure out configuration.

@ejsmith
Copy link
Contributor

ejsmith commented Mar 31, 2024

Can we make sure pushing and popping work on STJ arrays?

@lahma
Copy link
Collaborator Author

lahma commented Mar 31, 2024

Can we make sure pushing and popping work on STJ arrays?

Yes we can. Anyone needing such a feature is welcome to submit the implementation via a PR. Here i'm investigating minimal read model OOTB experience.

@ejsmith
Copy link
Contributor

ejsmith commented Mar 31, 2024

Thank you. I have been looking into it a bit and trying to understand the code and figure out where the right place to do so would be.

@ejsmith
Copy link
Contributor

ejsmith commented Mar 31, 2024

Not sure if you will be interested to take my other PR for adding push and pop support to interop arrays, but I pulled this branch down and tried to get it working on JsonArray. I did get it working, but it's pretty hacky. If this PR lands, then I will create a new PR on top to discuss.

@lahma lahma merged commit 198f4f7 into sebastienros:main Apr 1, 2024
3 checks passed
@lahma lahma deleted the native-stj branch April 1, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants