Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnwrapIfPromise Call RunAvailableContinuations #1813

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

scgm0
Copy link
Contributor

@scgm0 scgm0 commented Mar 21, 2024

No description provided.

@scgm0 scgm0 force-pushed the UnwrapIfPromise branch 3 times, most recently from c434013 to 6ef76e5 Compare March 21, 2024 16:04
@lahma lahma merged commit b6f99b9 into sebastienros:main Apr 5, 2024
3 checks passed
@lahma
Copy link
Collaborator

lahma commented Apr 5, 2024

Thank you!

@scgm0
Copy link
Contributor Author

scgm0 commented Apr 5, 2024

Thank you! 谢谢你!

This PR is a strange temporary scheme, should it really be merged?

@lahma
Copy link
Collaborator

lahma commented Apr 5, 2024

I can't make head or tails about that comment.

@scgm0
Copy link
Contributor Author

scgm0 commented Apr 5, 2024

I can't make head or tails about that comment.我对这个评论无法做出正确的判断。

Now that the matter is over, let’s wait and see if anyone will encounter problems because of this PR. It won’t be difficult to cancel it.

@lahma
Copy link
Collaborator

lahma commented Apr 5, 2024

Next time maybe you can add some information to the pull request about you being unsure if your makes sense? Ideally every pull request should have descriptive description. From now on I'll try to to have extreme prejudice against the PRs...

@scgm0
Copy link
Contributor Author

scgm0 commented Apr 5, 2024

Next time maybe you can add some information to the pull request about you being unsure if your makes sense? Ideally every pull request should have descriptive description. From now on I'll try to to have extreme prejudice against the PRs...下次也许你可以在拉取请求中添加一些关于你不确定你的想法是否有意义的信息?理想情况下,每个拉取请求都应该有描述性描述。从现在开始我会尽量对PR抱有极端的偏见......

ok, I really should have made it a draft, although it has been working on my own project for a while, but still not sure it's problem-free. . .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants