Improve interop performance against CLR list types #1792

lahma · 2024-02-25T15:34:33Z

Jint.Benchmark.ListInteropBenchmark

Diff	Method	Toolchain	Mean	Error	Allocated
Old	Filter	Default	967.84 μs	12.909 μs	1935.49 KB
New		Default	704.80 μs (-27%)	13.149 μs	973936 B (-51%)
Old	Indexing	Default	305.84 μs	4.030 μs	113.96 KB
New		Default	263.17 μs (-14%)	3.922 μs	92667 B (-21%)
Old	HasProperty	Default	18.40 μs	0.246 μs	30.97 KB
New		Default	11.17 μs (-39%)	0.090 μs	32 B (-100%)

sebastienros · 2024-02-26T17:51:38Z

Jint.Benchmark/ListInteropBenchmark.cs

+        return false;
+    }
+
+    private const int Count = 10_00;


I used sharplab to be sure what it was ;) Now I am even more confused by the location of the _

Hah, probably did some testing and forgot to remove the underscore which should be used as a thousand separator 😆

lahma force-pushed the list-interop-perf branch from d7bc120 to d936723 Compare February 25, 2024 15:35

Improve interop performance against CLR list types

32ea2a7

lahma force-pushed the list-interop-perf branch from d936723 to 32ea2a7 Compare February 25, 2024 15:49

lahma enabled auto-merge (squash) February 25, 2024 15:53

lahma merged commit 895b8d4 into sebastienros:main Feb 25, 2024
3 checks passed

lahma deleted the list-interop-perf branch February 25, 2024 15:54

sebastienros reviewed Feb 26, 2024

View reviewed changes