Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implicit convert DataView and ArrayBuffer to byte array #1786

Merged
merged 1 commit into from
Feb 21, 2024
Merged

feat: implicit convert DataView and ArrayBuffer to byte array #1786

merged 1 commit into from
Feb 21, 2024

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Feb 21, 2024 •
edited
Loading

  • resolves Accessing bytes of ArrayBuffer #1785
  • implicit convert DataView and ArrayBuffer to byte[] when calling ToObject for interop
  • add JsValue extensions to handle and convert those types when return from engine

lahma
lahma approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@lahma lahma merged commit c2bb947 into sebastienros:main Feb 21, 2024
3 checks passed
@viceice viceice deleted the feat/more-coersions branch February 21, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@viceice @lahma