Code changes to keep NET 8 analyzers happy #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
net8-analyzers
branch
from
153e740
to
3139783
Compare
lahma
force-pushed
the
net8-analyzers
branch
from
3139783
to
26f42ac
Compare
| @@ -605,7 +605,7 @@ public JsValue Escape(JsValue thisObject, JsValue[] arguments) | |||
| for (var k = 0; k < strLen; k++) | |||
| { | |||
| var c = uriString[k]; | |||
| if (WhiteList.IndexOf(c) != -1) | |||
| if (AllowList.Contains(c)) | |||
There was a problem hiding this comment.
This list can be ordered, so we should be able to use a binary search instead of Contains.
We also need to use SearchValues in some places, probably mostly in Esprima. But that means a net8.0 target.
There was a problem hiding this comment.
Added naive shim for this https://github.com/lahma/jint/blob/6553ee63a87139a8da0e0fbda3f2bfa6a8a6e9ef/Jint/Extensions/SearchValues.cs so can use with both NET 8 and older.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.