Added support to convert JsTypedArray when converting objects. #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some utility extensions for float typed arrays. Added tests for changes.
graphnode
force-pushed
the
jstypedarrays-as-arrays
branch
from
bac5e8a
to
38a54da
Compare
lahma
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some utility extensions for float typed arrays and added tests for the changes.
Now when using custom type converters or the DefaultTypeConverter JsTypedArrays should be converted correctly to CLR arrays.
Tried to avoid boxing so it uses _arrayElementType to directly convert to the proper array type using the ToNativeArray generic method.
Should close issue #1641.