Change JsDate.ToString to follow Date prototype logic #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
Feb 7, 2023
Jint/Native/JsDate.cs
Outdated
| @@ -56,6 +56,6 @@ public override string ToString() | |||
| return "Infinity"; | |||
| } | |||
|
|
|||
| return ToDateTime().ToString("ddd MMM dd yyyy HH:mm:ss 'GMT'zzz", CultureInfo.InvariantCulture); | |||
| return _engine.Realm.Intrinsics.Date.PrototypeObject.ToDateString(DateValue).ToString(); | |||
There was a problem hiding this comment.
do other JS object follow this pattern?
There was a problem hiding this comment.
well the primitives are quite limited with toString, should we just ignore this - don't you like the behavior?
There was a problem hiding this comment.
Well JsNumber does follow JS semantincs:
public override string ToString()
{
return TypeConverter.ToString(_value);
}
There was a problem hiding this comment.
Changed to use TypeConverter here too
sebastienros
approved these changes
Feb 7, 2023
|
Not sure we need the new dependency. I love the library, use it in Fluid also, but in this case we just need a culture info, we can just use a string that is known from both linux and windows in dotnet core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1424