The getDate() method returns 0 for December 31st before 1970 (#1746)

Co-authored-by: Pisotskyi Pavel <[email protected]>
sebastienros · Jan 18, 2024 · c4e5ce2 · c4e5ce2
1 parent 511523b
commit c4e5ce2
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/Jint.Tests/Runtime/DateTests.cs b/Jint.Tests/Runtime/DateTests.cs
@@ -104,6 +104,27 @@ public void CanParseLocaleString(string input, long expected)
         Assert.Equal(expected, _engine.Evaluate($"new Date('{input}') * 1").AsNumber());
     }
 
+    [Theory]
+    [InlineData("December 31 1900 12:00:00 +0300", 31)]
+    [InlineData("January 1 1969 12:00:00 +0300", 1)]
+    [InlineData("December 31 1969 12:00:00 +0300", 31)]
+    [InlineData("January 1 1970 12:00:00 +0300", 1)]
+    [InlineData("December 31 1970 12:00:00 +0300", 31)]
+    public void CanParseDate(string input, int expectedDate)
+    {
+        TimeZoneInfo timeZoneInfo;
+        try
+        {
+            timeZoneInfo = TimeZoneInfo.FindSystemTimeZoneById("Europe/Kiev");
+        }
+        catch
+        {
+            timeZoneInfo = TimeZoneInfo.FindSystemTimeZoneById("FLE Standard Time");
+        }
+        var engine = new Engine(options => options.LocalTimeZone(timeZoneInfo));
+        Assert.Equal(expectedDate, _engine.Evaluate($"new Date('{input}').getDate()").AsNumber());
+    }
+
     [Fact]
     public void CanUseMoment()
     {

diff --git a/Jint/Native/Date/DatePrototype.cs b/Jint/Native/Date/DatePrototype.cs
@@ -1270,7 +1270,7 @@ private static bool AreFinite(double value1, double value2, double value3, doubl
 
         private static readonly int[] kDaysInMonths = {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};
 
-        private static Date YearMonthDayFromTime(DatePresentation t) => YearMonthDayFromDays(t.Value / 1000 / 60 / 60 / 24);
+        private static Date YearMonthDayFromTime(DatePresentation t) => YearMonthDayFromDays((long) System.Math.Floor(t.Value / 1000 / 60 / 60 / 24d));
 
         private static Date YearMonthDayFromDays(long days)
         {