Remove explicit Newtonsoft.Json package reference (#1799)

sebastienros · Mar 8, 2024 · a506d91 · a506d91
1 parent 107f543
commit a506d91
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 13 deletions.
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -15,7 +15,6 @@
     <PackageVersion Include="Microsoft.Extensions.TimeProvider.Testing" Version="8.0.0" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
     <PackageVersion Include="MongoDB.Bson.signed" Version="2.19.0" />
-    <PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageVersion Include="NiL.JS" Version="2.5.1677" />
     <PackageVersion Include="NodaTime" Version="3.1.9" />
     <PackageVersion Include="NUnit" Version="4.0.1" />

diff --git a/Jint.Benchmark/Jint.Benchmark.csproj b/Jint.Benchmark/Jint.Benchmark.csproj
@@ -26,7 +26,6 @@
   <ItemGroup>
     <PackageReference Include="BenchmarkDotNet" />
     <PackageReference Include="Jurassic" />
-    <PackageReference Include="Newtonsoft.Json" />
     <PackageReference Include="NiL.JS" />
     <PackageReference Include="YantraJS.Core" />
   </ItemGroup>

diff --git a/Jint.Benchmark/UncacheableExpressionsBenchmark.cs b/Jint.Benchmark/UncacheableExpressionsBenchmark.cs
@@ -1,7 +1,7 @@
 using System.Text;
+using System.Text.Json;
 using BenchmarkDotNet.Attributes;
 using Jint.Native;
-using Newtonsoft.Json;
 
 namespace Jint.Benchmark;
 
@@ -64,14 +64,10 @@ public void Setup()
 
         using (var stream = new MemoryStream())
         {
-            using (var writer = new StreamWriter(stream))
-            {
-                JsonSerializer.CreateDefault().Serialize(writer, doc);
-                writer.Flush();
+            JsonSerializer.Serialize(stream, doc);
 
-                var targetObjectJson = Encoding.UTF8.GetString(stream.ToArray());
-                targetObject = $"var d = {targetObjectJson};";
-            }
+            var targetObjectJson = Encoding.UTF8.GetString(stream.ToArray());
+            targetObject = $"var d = {targetObjectJson};";
         }
 
         CreateEngine(Arrow ? ArrowFunctionScript : NonArrowFunctionScript);
@@ -107,6 +103,6 @@ private void CreateEngine(string script)
         engine = new Engine(InitializeEngine);
         engine.Execute(script);
         engine.Execute(targetObject);
-        targetJsObject = new[] {engine.GetValue("d")};
+        targetJsObject = new[] { engine.GetValue("d") };
     }
 }
diff --git a/Jint.Tests.PublicInterface/Jint.Tests.PublicInterface.csproj b/Jint.Tests.PublicInterface/Jint.Tests.PublicInterface.csproj
@@ -25,7 +25,6 @@
     <PackageReference Include="Flurl.Http.Signed" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
     <PackageReference Include="MongoDB.Bson.signed" />
-    <PackageReference Include="Newtonsoft.Json" />
     <PackageReference Include="NodaTime" />
     <PackageReference Include="Microsoft.Extensions.TimeProvider.Testing" />
     <PackageReference Include="System.Text.Json" />

diff --git a/Jint.Tests/Jint.Tests.csproj b/Jint.Tests/Jint.Tests.csproj
@@ -29,7 +29,6 @@
     <PackageReference Include="Microsoft.Extensions.DependencyInjection" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
     <PackageReference Include="MongoDB.Bson.signed" />
-    <PackageReference Include="Newtonsoft.Json" />
     <PackageReference Include="System.Text.Json" />
     <PackageReference Include="xunit" />
     <PackageReference Include="xunit.runner.visualstudio" />