Rename thisObj to thisObject and args as arguments in parameter names (…

…#1597)
sebastienros · Jul 30, 2023 · 2ec677c · 2ec677c
1 parent ac1cec8
commit 2ec677c
Show file tree

Hide file tree

Showing 40 changed files with 686 additions and 693 deletions.
diff --git a/Jint.Tests/Runtime/Domain/UuidPrototype.cs b/Jint.Tests/Runtime/Domain/UuidPrototype.cs
@@ -11,17 +11,14 @@ private UuidPrototype(Engine engine) : base(engine)
         {
         }
 
-        private UuidInstance EnsureUuidInstance(JsValue thisObj)
+        private UuidInstance EnsureUuidInstance(JsValue thisObject)
         {
-            return thisObj.TryCast<UuidInstance>(value =>
-            {
-                throw new JavaScriptException(Engine.Realm.Intrinsics.TypeError, "Invalid Uuid");
-            });
+            return thisObject.TryCast<UuidInstance>(value => throw new JavaScriptException(Engine.Realm.Intrinsics.TypeError, "Invalid Uuid"));
         }
 
-        private JsValue ToGuidString(JsValue thisObj, JsValue[] arguments) => EnsureUuidInstance(thisObj).PrimitiveValue.ToString();
+        private JsValue ToGuidString(JsValue thisObject, JsValue[] arguments) => EnsureUuidInstance(thisObject).PrimitiveValue.ToString();
 
-        private JsValue ValueOf(JsValue thisObj, JsValue[] arguments) => EnsureUuidInstance(thisObj).PrimitiveValue;
+        private JsValue ValueOf(JsValue thisObject, JsValue[] arguments) => EnsureUuidInstance(thisObject).PrimitiveValue;
 
         public static UuidPrototype CreatePrototypeObject(Engine engine, UuidConstructor ctor)
         {

diff --git a/Jint/Native/Array/ArrayConstructor.cs b/Jint/Native/Array/ArrayConstructor.cs
@@ -49,7 +49,7 @@ protected override void Initialize()
         /// <summary>
         /// https://tc39.es/ecma262/#sec-array.from
         /// </summary>
-        private JsValue From(JsValue thisObj, JsValue[] arguments)
+        private JsValue From(JsValue thisObject, JsValue[] arguments)
         {
             var items = arguments.At(0);
             var mapFunction = arguments.At(1);
@@ -65,9 +65,9 @@ private JsValue From(JsValue thisObj, JsValue[] arguments)
             if (usingIterator is not null)
             {
                 ObjectInstance instance;
-                if (!ReferenceEquals(this, thisObj) && thisObj is IConstructor constructor)
+                if (!ReferenceEquals(this, thisObject) && thisObject is IConstructor constructor)
                 {
-                    instance = constructor.Construct(System.Array.Empty<JsValue>(), thisObj);
+                    instance = constructor.Construct(System.Array.Empty<JsValue>(), thisObject);
                 }
                 else
                 {
@@ -86,7 +86,7 @@ private JsValue From(JsValue thisObj, JsValue[] arguments)
                 return ConstructArrayFromIEnumerable(enumerable);
             }
 
-            return ConstructArrayFromArrayLike(thisObj, objectInstance, callable, thisArg);
+            return ConstructArrayFromArrayLike(thisObject, objectInstance, callable, thisArg);
         }
 
         private ObjectInstance ConstructArrayFromArrayLike(
@@ -160,15 +160,15 @@ public ArrayProtocol(
                 _callable = callable;
             }
 
-            protected override void ProcessItem(JsValue[] args, JsValue currentValue)
+            protected override void ProcessItem(JsValue[] arguments, JsValue currentValue)
             {
                 _index++;
                 JsValue jsValue;
                 if (!ReferenceEquals(_callable, null))
                 {
-                    args[0] = currentValue;
-                    args[1] = _index;
-                    jsValue = _callable.Call(_thisArg, args);
+                    arguments[0] = currentValue;
+                    arguments[1] = _index;
+                    jsValue = _callable.Call(_thisArg, arguments);
                 }
                 else
                 {
@@ -184,13 +184,13 @@ protected override void IterationEnd()
             }
         }
 
-        private JsValue Of(JsValue thisObj, JsValue[] arguments)
+        private JsValue Of(JsValue thisObject, JsValue[] arguments)
         {
             var len = arguments.Length;
             ObjectInstance a;
-            if (thisObj.IsConstructor)
+            if (thisObject.IsConstructor)
             {
-                a = ((IConstructor) thisObj).Construct(new JsValue[] { len }, thisObj);
+                a = ((IConstructor) thisObject).Construct(new JsValue[] { len }, thisObject);
             }
             else
             {
@@ -227,7 +227,7 @@ private static JsValue Species(JsValue thisObject, JsValue[] arguments)
             return thisObject;
         }
 
-        private static JsValue IsArray(JsValue thisObj, JsValue[] arguments)
+        private static JsValue IsArray(JsValue thisObject, JsValue[] arguments)
         {
             var o = arguments.At(0);