Skip to content

Capitalize filter should make the first letter capital #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hishamco merged 3 commits into from
Mar 25, 2026
+4 −8
Merged

Capitalize filter should make the first letter capital #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfdd525
Capitalize filter should make the first letter capital
hishamco Mar 25, 2026
7cf0391
Merge branch 'main' into hishamco/capitalize
hishamco Mar 25, 2026
c524179
Fix the broken test
hishamco Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Fluid.Tests/StringFiltersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Linq;
using System.Linq;
using System.Threading.Tasks;
using Fluid.Values;
using Fluid.Filters;
Expand Down Expand Up @@ -32,7 +32,7 @@ public void Capitalize()

var result = StringFilters.Capitalize(input, arguments, context);

Assert.Equal("Hello World", result.Result.ToStringValue());
Assert.Equal("Hello world", result.Result.ToStringValue());
}

[Fact]
Expand Down
8 changes: 2 additions & 6 deletions Fluid/Filters/StringFilters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,9 @@ public static ValueTask<FluidValue> Capitalize(FluidValue input, FilterArguments

var source = input.ToStringValue().ToCharArray();

for (var i = 0; i < source.Length; i++)
if (source.Length > 0 && char.IsLetter(source[0]))
{
char c;
if (i == 0 || char.IsWhiteSpace(c = source[i - 1]) || c == '-' || c == '.')
{
source[i] = char.ToUpper(source[i], context.CultureInfo);
}
source[0] = char.ToUpper(source[0], context.CultureInfo);
}

return CreateStringValue(new string(source), input);
Expand Down